diff --git a/mmengine/hooks/logger_hook.py b/mmengine/hooks/logger_hook.py index 01f5fccd1acf67bfd4dbe5843a5265dc13093ddb..a35ce2ee4f9eb9bf556886ecbf0d39316ff6fa5b 100644 --- a/mmengine/hooks/logger_hook.py +++ b/mmengine/hooks/logger_hook.py @@ -214,10 +214,7 @@ class LoggerHook(Hook): # by iter. At the same time, scalars related to time should # still be logged by iter to avoid messy visualized result. # see details in PR #278. - time_tags = {k: v for k, v in tag.items() if 'time' in k} metric_tags = {k: v for k, v in tag.items() if 'time' not in k} - runner.visualizer.add_scalars( - time_tags, step=runner.iter, file_path=self.json_log_path) runner.visualizer.add_scalars( metric_tags, step=runner.epoch, file_path=self.json_log_path) else: diff --git a/tests/test_hook/test_logger_hook.py b/tests/test_hook/test_logger_hook.py index 50fd4562c0e60a90f83be6961d9b58f15a55b9a8..230355ccb0a149b3b4c8f2ce05c212c60265626d 100644 --- a/tests/test_hook/test_logger_hook.py +++ b/tests/test_hook/test_logger_hook.py @@ -128,12 +128,7 @@ class TestLoggerHook: logger_hook.after_val_epoch(runner) args = {'step': ANY, 'file_path': ANY} # expect visualizer log `time` and `metric` respectively - runner.visualizer.add_scalars.assert_any_call( - { - 'time': 1, - 'datatime': 1 - }, **args) - runner.visualizer.add_scalars.assert_any_call({'acc': 0.8}, **args) + runner.visualizer.add_scalars.assert_called_with({'acc': 0.8}, **args) # Test when `log_metric_by_epoch` is False logger_hook = LoggerHook(log_metric_by_epoch=False) @@ -145,7 +140,7 @@ class TestLoggerHook: }, 'string')) logger_hook.after_val_epoch(runner) # expect visualizer log `time` and `metric` jointly - runner.visualizer.add_scalars.assert_any_call( + runner.visualizer.add_scalars.assert_called_with( { 'time': 5, 'datatime': 5,