From 6bd548d8bb29a28040a6cb0d6d191cad14713dad Mon Sep 17 00:00:00 2001
From: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Date: Wed, 20 Jul 2022 16:51:11 +0800
Subject: [PATCH] [FIx] Logging time in LoggerHook.after_val_epoch has no
effect (#376)
---
mmengine/hooks/logger_hook.py | 3 ---
tests/test_hook/test_logger_hook.py | 9 ++-------
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/mmengine/hooks/logger_hook.py b/mmengine/hooks/logger_hook.py
index 01f5fccd..a35ce2ee 100644
--- a/mmengine/hooks/logger_hook.py
+++ b/mmengine/hooks/logger_hook.py
@@ -214,10 +214,7 @@ class LoggerHook(Hook):
# by iter. At the same time, scalars related to time should
# still be logged by iter to avoid messy visualized result.
# see details in PR #278.
- time_tags = {k: v for k, v in tag.items() if 'time' in k}
metric_tags = {k: v for k, v in tag.items() if 'time' not in k}
- runner.visualizer.add_scalars(
- time_tags, step=runner.iter, file_path=self.json_log_path)
runner.visualizer.add_scalars(
metric_tags, step=runner.epoch, file_path=self.json_log_path)
else:
diff --git a/tests/test_hook/test_logger_hook.py b/tests/test_hook/test_logger_hook.py
index 50fd4562..230355cc 100644
--- a/tests/test_hook/test_logger_hook.py
+++ b/tests/test_hook/test_logger_hook.py
@@ -128,12 +128,7 @@ class TestLoggerHook:
logger_hook.after_val_epoch(runner)
args = {'step': ANY, 'file_path': ANY}
# expect visualizer log `time` and `metric` respectively
- runner.visualizer.add_scalars.assert_any_call(
- {
- 'time': 1,
- 'datatime': 1
- }, **args)
- runner.visualizer.add_scalars.assert_any_call({'acc': 0.8}, **args)
+ runner.visualizer.add_scalars.assert_called_with({'acc': 0.8}, **args)
# Test when `log_metric_by_epoch` is False
logger_hook = LoggerHook(log_metric_by_epoch=False)
@@ -145,7 +140,7 @@ class TestLoggerHook:
}, 'string'))
logger_hook.after_val_epoch(runner)
# expect visualizer log `time` and `metric` jointly
- runner.visualizer.add_scalars.assert_any_call(
+ runner.visualizer.add_scalars.assert_called_with(
{
'time': 5,
'datatime': 5,
--
GitLab