From 755f8b5b59e6fdf617262efccc75a6dea73e635c Mon Sep 17 00:00:00 2001
From: Yuan Liu <30762564+YuanLiuuuuuu@users.noreply.github.com>
Date: Sat, 12 Mar 2022 10:47:06 +0800
Subject: [PATCH] [Refactor]: Change scheduler to param_scheduler (#121)
* [Refactor]: Change scheduler to param_scheduler
* [Fix]: Fix UT of param scheduler hook
Co-authored-by: Your <you@example.com>
---
mmengine/hooks/param_scheduler_hook.py | 4 ++--
tests/test_hook/test_param_scheduler_hook.py | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/mmengine/hooks/param_scheduler_hook.py b/mmengine/hooks/param_scheduler_hook.py
index a85ef3ac..cb2e5fbd 100644
--- a/mmengine/hooks/param_scheduler_hook.py
+++ b/mmengine/hooks/param_scheduler_hook.py
@@ -31,7 +31,7 @@ class ParamSchedulerHook(Hook):
In order to keep this interface consistent with other hooks, we
keep ``data_batch`` here. Defaults to None.
"""
- for scheduler in runner.schedulers:
+ for scheduler in runner.param_schedulers: # type: ignore
if not scheduler.by_epoch:
scheduler.step()
@@ -41,6 +41,6 @@ class ParamSchedulerHook(Hook):
Args:
runner (Runner): The runner of the training process.
"""
- for scheduler in runner.schedulers:
+ for scheduler in runner.param_schedulers: # type: ignore
if scheduler.by_epoch:
scheduler.step()
diff --git a/tests/test_hook/test_param_scheduler_hook.py b/tests/test_hook/test_param_scheduler_hook.py
index f944d3ed..8b569d51 100644
--- a/tests/test_hook/test_param_scheduler_hook.py
+++ b/tests/test_hook/test_param_scheduler_hook.py
@@ -12,7 +12,7 @@ class TestParamSchedulerHook:
scheduler = Mock()
scheduler.step = Mock()
scheduler.by_epoch = False
- Runner.schedulers = [scheduler]
+ Runner.param_schedulers = [scheduler]
Hook.after_train_iter(Runner)
scheduler.step.assert_called()
@@ -22,6 +22,6 @@ class TestParamSchedulerHook:
scheduler = Mock()
scheduler.step = Mock()
scheduler.by_epoch = True
- Runner.schedulers = [scheduler]
+ Runner.param_schedulers = [scheduler]
Hook.after_train_epoch(Runner)
scheduler.step.assert_called()
--
GitLab