From 72b934f7fce38ee332928d3527984ad0dae3261e Mon Sep 17 00:00:00 2001
From: Hashem Tatari <hashem.tatari@exset.com>
Date: Thu, 24 Jan 2019 16:43:43 +0100
Subject: [PATCH] Update the launch_terminal definition in case of using
 LAUNCH_TERMINAL

Add quotes around the soc_term and the port number to make it compatible
with other terminals like terminator.

To use terminator, it is enough to set the flag like:
$ export LAUNCH_TERMINAL="terminator -e"
$ make run-only

Note when using the LAUNCH_TERMINAL the title of the terminals cannot
be set separately so better to ignore the titles

Signed-off-by: Hashem Tatari <hashem.tatari@exset.com>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
---
 common.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/common.mk b/common.mk
index 48c31d4..55afbfe 100644
--- a/common.mk
+++ b/common.mk
@@ -336,10 +336,12 @@ define run-help
 	@echo
 endef
 
+# Note: Using the LAUNCH_TERMINAL environment variable, it is not currently possible to set 
+# different titles for the terminals because there is no any common way among all the terminals
 ifneq (, $(LAUNCH_TERMINAL))
 define launch-terminal
 	@nc -z  127.0.0.1 $(1) || \
-		$(LAUNCH_TERMINAL) $(SOC_TERM_PATH)/soc_term $(1) &
+		$(LAUNCH_TERMINAL) "$(SOC_TERM_PATH)/soc_term $(1)" &
 endef
 else
 gnome-terminal := $(shell command -v gnome-terminal 2>/dev/null)
-- 
GitLab