diff --git a/Scheduler/EventHook.cci b/Scheduler/EventHook.cci index 89e1b1a10b38d6ec31dd344a49b4c2f62c6cdb0c..8cbec85410f5429d2f99898a8705294549c5179d 100644 --- a/Scheduler/EventHook.cci +++ b/Scheduler/EventHook.cci @@ -34,8 +34,8 @@ // senf::scheduler::EventHook prefix_ senf::scheduler::EventHook::EventHook(std::string const & name, Callback const & cb, - bool initiallyEnabled, - detail::FIFORunner::TaskInfo::Priority priority) + detail::FIFORunner::TaskInfo::Priority priority, + bool initiallyEnabled) : detail::FIFORunner::TaskInfo(name, priority), cb_ (cb) { if (initiallyEnabled) diff --git a/Scheduler/EventHook.hh b/Scheduler/EventHook.hh index 44377803529232c9af57b1c06f59b7cd964ddaf6..0ab24c963932c20bed002242bd2d58a526b419bc 100644 --- a/Scheduler/EventHook.hh +++ b/Scheduler/EventHook.hh @@ -82,7 +82,7 @@ namespace scheduler { ///@{ EventHook(std::string const & name, Callback const & cb, - bool initiallyEnabled = true, Priority priority = POST); + Priority priority, bool initiallyEnabled = true); ///< Register an event hook /**< Registers \a cb to be called whenever any other event is signaled by the scheduler. If \a initiallyEnabled is diff --git a/Scheduler/Scheduler.test.cc b/Scheduler/Scheduler.test.cc index 0a135182e2abfe34b4d070d822365eab52d4c629..14e01bc0586b459bd3d9fb021e6e00b96b7e2f8a 100644 --- a/Scheduler/Scheduler.test.cc +++ b/Scheduler/Scheduler.test.cc @@ -242,8 +242,8 @@ void schedulerTest() /////////////////////////////////////////////////////////////////////////// - senf::scheduler::EventHook evev ("eventCounter", eventeventhandler, true, - senf::scheduler::EventHook::PRE); + senf::scheduler::EventHook evev ("eventCounter", eventeventhandler, + senf::scheduler::EventHook::PRE); { senf::scheduler::FdEvent fde1 ("testFdEvent", boost::bind(&callback, sock, _1), diff --git a/Scheduler/TimerEvent.test.cc b/Scheduler/TimerEvent.test.cc index ff410e90cdfcbeadc5fa8b85530f85f36cc29367..7801ad199115b184f27b099359672a65e3332994 100644 --- a/Scheduler/TimerEvent.test.cc +++ b/Scheduler/TimerEvent.test.cc @@ -96,24 +96,37 @@ namespace { unsigned count (0); senf::ClockService::clock_type delay (0); + bool haveCb (false); void jitterCb(senf::scheduler::TimerEvent & tm) { std::cerr << senf::scheduler::now() << ' ' << tm.timeout() << '\n'; count ++; delay += senf::scheduler::now() - tm.timeout(); + haveCb = true; tm.timeout(randomDelay()); } - void logSchedulerTime() + void preCb() { - std::cerr << senf::scheduler::now() << '\n'; + haveCb = false; + } + + void postCb() + { + if (! haveCb) + std::cerr << senf::scheduler::now() << '\n'; } void jitterTest() { count = 0; delay = 0; + senf::scheduler::EventHook pre ("jitterTest::preCb", &preCb, + senf::scheduler::EventHook::PRE); + senf::scheduler::EventHook post ("jitterTest::postCb", &postCb, + senf::scheduler::EventHook::POST); + senf::scheduler::TimerEvent tm1 ("jitterTest::tm1", boost::bind(&jitterCb, boost::ref(tm1)), randomDelay()); senf::scheduler::TimerEvent tm2 ("jitterTest::tm2", boost::bind(&jitterCb, boost::ref(tm2)), @@ -124,9 +137,6 @@ namespace { senf::scheduler::TimerEvent timeout("jitterTest::timeout", &senf::scheduler::terminate, senf::scheduler::now() + senf::ClockService::seconds(5)); - senf::scheduler::EventHook timerCalled ("jitterTest::logSchedulerTime", &logSchedulerTime, - senf::scheduler::EventHook::PRE); - senf::scheduler::process(); std::cerr << "Average scheduling delay: " << delay/count << "\n";