From 346b1648600cc2779f56f5b90091011eac974824 Mon Sep 17 00:00:00 2001
From: g0dil <g0dil@wiback.org>
Date: Sat, 14 Apr 2007 10:07:08 +0000
Subject: [PATCH] Adjust some fixme/todo items Fix search layout to work
acceptably in all browsers
---
Packets/Packet.cc | 2 +-
Packets/Packet.cti | 3 --
Packets/Packet.hh | 2 --
Packets/ParseListS.ct | 1 +
Packets/ParseVec.ct | 2 +-
doclib/doxy-header-overview.html | 4 +--
doclib/doxy-header.html | 4 +--
doclib/html-munge.xsl | 6 +++-
doclib/search.php | 4 +--
doclib/senf.css | 56 +++++++++++++++++++++++---------
10 files changed, 55 insertions(+), 29 deletions(-)
diff --git a/Packets/Packet.cc b/Packets/Packet.cc
index 9b1d68aa6..b1b2e1796 100644
--- a/Packets/Packet.cc
+++ b/Packets/Packet.cc
@@ -270,7 +270,7 @@ prefix_ void senf::Packet::erase(iterator first, iterator last)
size_type index(first-impl_->data_.begin());
size_type sz(last-first);
BOOST_ASSERT( index >= begin_ && index < end_ && sz <= end_-index );
- /** \fixme Here we should assert, that no bytes belonging to the
+ /** \todo Here we should assert, that no bytes belonging to the
next iterator are deleted ... */
impl_->data_.erase(first,last);
impl_->updateIterators(index,-sz,self_,INSIDE);
diff --git a/Packets/Packet.cti b/Packets/Packet.cti
index 719663d17..9963d1647 100644
--- a/Packets/Packet.cti
+++ b/Packets/Packet.cti
@@ -50,9 +50,6 @@ prefix_ senf::Packet::Packet(Operation const & arg)
parsed_(false), refcount_(1)
{
SATCOM_PKF_REFC_MSG("] Packet::Packet (" << this << "): refcount_ = 1\n");
- /** \fixme This is not exception safe, if an exception is thrown in
- the derived class constuctor, the effects of this call must be
- undone which is not possible in a simple way. */
arg(this);
}
diff --git a/Packets/Packet.hh b/Packets/Packet.hh
index dd913d6a5..64fcb78bb 100644
--- a/Packets/Packet.hh
+++ b/Packets/Packet.hh
@@ -260,8 +260,6 @@ namespace senf {
intrusive_ptr is only the size of an ordinary pointer, a
smart_ptr has the size of two pointers).
- \fixme Make all data mutators protected
-
\nosubgrouping
*/
class Packet : boost::noncopyable
diff --git a/Packets/ParseListS.ct b/Packets/ParseListS.ct
index 56388a872..ba893600b 100644
--- a/Packets/ParseListS.ct
+++ b/Packets/ParseListS.ct
@@ -108,6 +108,7 @@ senf::Parse_ListS_wrapper<Parser,Sentinel,Container>::insert(iterator pos,
InputIterator f,
InputIterator l)
{
+ /** \todo Optimize this for random-access and multi-pass iterators */
for (;f!=l;++f,++pos) insert(pos,*f);
}
diff --git a/Packets/ParseVec.ct b/Packets/ParseVec.ct
index 4f20faddd..6ef4055ed 100644
--- a/Packets/ParseVec.ct
+++ b/Packets/ParseVec.ct
@@ -61,7 +61,7 @@ senf::Parse_Vector_wrapper<Parser,SizeParser,Container>::insert(iterator pos,
InputIterator f,
InputIterator l)
{
- /** \fixme This might be horribly inefficient ... we need to
+ /** \todo This might be horribly inefficient ... we need to
specialize for random_access and forward iterators, where we
can count the distance */
diff --git a/doclib/doxy-header-overview.html b/doclib/doxy-header-overview.html
index 050cc2bd5..195b602e2 100644
--- a/doclib/doxy-header-overview.html
+++ b/doclib/doxy-header-overview.html
@@ -11,13 +11,13 @@ div.tabs ul li.$projectname a { background-color: #EDE497; }
<body>
<div id="head">
- <h1>SENF Extensible Network Framework</h1>
- <h2>Introduction and Overview</h2>
<div id="search">
<form action="../../doclib/search.php" method="get">
Search: <input type="text" name="query" size="20" accesskey="s"/>
</form>
</div>
+ <h1>SENF Extensible Network Framework</h1>
+ <h2>Introduction and Overview</h2>
</div>
<div id="content1">
diff --git a/doclib/doxy-header.html b/doclib/doxy-header.html
index ba83bb6b3..f05fb454b 100644
--- a/doclib/doxy-header.html
+++ b/doclib/doxy-header.html
@@ -11,13 +11,13 @@ div.tabs ul li.$projectname a { background-color: #EDE497; }
<body>
<div id="head">
- <h1>SENF Extensible Network Framework</h1>
- <h2>Documentation and API reference</h2>
<div id="search">
<form action="../../../doclib/search.php" method="get">
Search: <input type="text" name="query" size="20" accesskey="s"/>
</form>
</div>
+ <h1>SENF Extensible Network Framework</h1>
+ <h2>Documentation and API reference</h2>
</div>
<div id="content1">
diff --git a/doclib/html-munge.xsl b/doclib/html-munge.xsl
index a7f17c3f8..e1cc7d6da 100644
--- a/doclib/html-munge.xsl
+++ b/doclib/html-munge.xsl
@@ -1,7 +1,11 @@
<?xml version="1.0" encoding="utf-8"?>
<xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform" version="1.0">
- <xsl:output method="html" encoding="html"/>
+ <xsl:output
+ method="html"
+ encoding="html"
+ doctype-public="-//W3C//DTD HTML 4.01 Transitional//EN"
+ doctype-system="http://www.w3.org/TR/html4/loose.dtd"/>
<xsl:template match="*">
<xsl:copy>
diff --git a/doclib/search.php b/doclib/search.php
index 7fc04f5a2..f5842fee9 100644
--- a/doclib/search.php
+++ b/doclib/search.php
@@ -9,13 +9,13 @@
<body>
<div id="head">
- <h1>SENF Extensible Network Framework</h1>
- <h2>Search Results</h2>
<div id="search">
<form action="search.php" method="get">
Search: <?php inputfield(); ?>
</form>
</div>
+ <h1>SENF Extensible Network Framework</h1>
+ <h2>Search Results</h2>
</div>
<div id="content1">
diff --git a/doclib/senf.css b/doclib/senf.css
index 5e3c48082..9cda254bb 100644
--- a/doclib/senf.css
+++ b/doclib/senf.css
@@ -5,7 +5,7 @@ body {
}
#head {
- height: 72px;
+ height: 62px;
border-top: 5px solid #DECD40;
border-bottom: 1px solid #AF9D00;
background: url(logo-head.png) top left no-repeat;
@@ -27,8 +27,8 @@ body {
#head h2 {
margin: 0 0 0 100px;
- padding: 6px 0 0 42px;
- height: 26px;
+ padding: 4px 0 0 42px;
+ height: 18px;
background-color: #EDE497;
color: #726921;
font-size: 13px;
@@ -37,9 +37,28 @@ body {
}
#search {
- position: absolute;
- top: 50px;
- right: 10px;
+ float: right;
+ width: 150px;
+ height: 39px;
+ font-size: 10px;
+ /* margin/padding/color/background-color/border: mostly IE6/IE7 fixes */
+ margin: 0 0 0 -10px;
+ padding: 0 10px 0 10px;
+ color: #726921;
+ background-color: #DECD40;
+ border-bottom: 1px solid #AF9D00;
+}
+
+#search input {
+ display: block;
+ height: 16px;
+ border: 1px solid #AF9D00;
+ width: 100%;
+}
+
+#search form {
+ margin: 0;
+ padding: 0;
}
#content1 {
@@ -67,8 +86,8 @@ a.ext {
}
a.anchor {
- color: inherit;
- background-color: white !important;
+ color: inherit;
+ background-color: white !important;
}
div.tabs {
@@ -226,23 +245,23 @@ dl.xref-idea {
}
div.bug, div.fixme, div.todo, div.idea {
- padding-left: 10px;
+ padding-left: 10px;
}
div.bug {
- border-left: 10px solid red;
+ border-left: 10px solid red;
}
div.fixme {
- border-left: 10px solid yellow;
+ border-left: 10px solid yellow;
}
div.todo {
- border-left: 10px solid green;
+ border-left: 10px solid green;
}
div.idea {
- border-left: 10px solid #AAAAAA;
+ border-left: 10px solid #AAAAAA;
}
table {
@@ -279,7 +298,7 @@ dl.parameters dd table {
table.glossary {
border: none;
border-spacing: 0;
- margin: 10px 0;
+ margin: 10px 0;
}
table.glossary tr td {
@@ -298,4 +317,11 @@ table.glossary tr td:first-child {
table.members td:first-child {
width: 35%;
-}
\ No newline at end of file
+}
+
+/*
+ * Local Variables:
+ * indent-tabs-mode: nil
+ * ispell-local-dictionary: "american"
+ * End:
+ */
--
GitLab