diff --git a/Examples/DVBAdapter/ULEdec.cc b/Examples/DVBAdapter/ULEdec.cc index f70b49fb17b1c451917e56571b0467e4b39921f2..8fc629d3299819eb15e1391e1af7e43e7f6ba986 100644 --- a/Examples/DVBAdapter/ULEdec.cc +++ b/Examples/DVBAdapter/ULEdec.cc @@ -67,7 +67,7 @@ void ULEdec::handleEvent(senf::Scheduler::EventId event) dvrHandle.read( ts_packet.data() ); // Check TS error conditions: sync_byte, transport_error_indicator, scrambling_control. - if ( (ts_packet->sync_byte() != TRANSPORT_PACKET_SYNC_BYTE) || + if ( (ts_packet->sync_byte() != senf::TransportPacketType::SYNC_BYTE) || (ts_packet->transport_error_indicator() == true) || (ts_packet->transport_scrmbl_ctrl() != 0)) { diff --git a/Examples/Sniffer/SConscript b/Examples/Sniffer/SConscript index 250abc6c4c40193629d1df0f3827a37eeb540063..ecf3cad4fa88c5ad26647dcb23a3a240b8cbde3c 100644 --- a/Examples/Sniffer/SConscript +++ b/Examples/Sniffer/SConscript @@ -3,9 +3,8 @@ import SENFSCons ########################################################################### -SENFSCons.Binary(env, 'sniffer', SENFSCons.GlobSources(), - LIBS = [ 'Scheduler', 'Packets', 'Socket', 'Utils' ], - OBJECTS = [ '#/Packets/DefaultBundle/DefaultBundle.o', - '#/Packets/MPEGDVBBundle/MPEGDVBBundle.o' ]) +SENFSCons.Binary(env, 'sniffer', SENFSCons.GlobSources(), LIBS = [ + 'Packets_DefaultBundle', 'Packets_MPEGDVBBundle', + 'Scheduler', 'Packets', 'Socket', 'Utils' ]) SENFSCons.Doxygen(env) diff --git a/Packets/MPEGDVBBundle/TransportPacket.hh b/Packets/MPEGDVBBundle/TransportPacket.hh index 36fd10fca3b7c8280f3f4212d83fbb7d2820ef0b..ab9d495e6fa1a7fec1674a3b508d2559fc58e335 100644 --- a/Packets/MPEGDVBBundle/TransportPacket.hh +++ b/Packets/MPEGDVBBundle/TransportPacket.hh @@ -119,13 +119,11 @@ namespace senf { using mixin::initSize; static void dump(packet p, std::ostream & os); + static const byte SYNC_BYTE = 0x47; }; /** \brief Transport packet typedef */ - typedef TransportPacketType::packet TransportPacket; - - #define TRANSPORT_PACKET_SYNC_BYTE 0x47 - + typedef ConcretePacket<TransportPacketType> TransportPacket; } diff --git a/Packets/MPEGDVBBundle/TransportPacket.test.cc b/Packets/MPEGDVBBundle/TransportPacket.test.cc index 9aa131f6c5f1ebdd8c5068a1fe127157833fff42..fc843de25a7bab9f1c835707a8f846d58dadf872 100644 --- a/Packets/MPEGDVBBundle/TransportPacket.test.cc +++ b/Packets/MPEGDVBBundle/TransportPacket.test.cc @@ -69,14 +69,14 @@ BOOST_AUTO_UNIT_TEST(transportPacket_packet) senf::TransportPacket p (senf::TransportPacket::create(data)); - BOOST_CHECK_EQUAL( p->sync_byte(), TRANSPORT_PACKET_SYNC_BYTE ); - BOOST_CHECK( ! p->transport_error_indicator() ); - BOOST_CHECK( p->pusi() ); - BOOST_CHECK( ! p->transport_priority() ); - BOOST_CHECK_EQUAL( p->pid(), 0x010fu ); - BOOST_CHECK_EQUAL( p->transport_scrmbl_ctrl(), 0x0u ); - BOOST_CHECK_EQUAL( p->adaptation_field_ctrl(), 0x1u ); - BOOST_CHECK_EQUAL( p->continuity_counter(), 0x0eu ); + BOOST_CHECK_EQUAL( p->sync_byte(), TransportPacketType::SYNC_BYTE ); + BOOST_CHECK( ! p->transport_error_indicator() ); + BOOST_CHECK( p->pusi() ); + BOOST_CHECK( ! p->transport_priority() ); + BOOST_CHECK_EQUAL( p->pid(), 0x010fu ); + BOOST_CHECK_EQUAL( p->transport_scrmbl_ctrl(), 0x0u ); + BOOST_CHECK_EQUAL( p->adaptation_field_ctrl(), 0x1u ); + BOOST_CHECK_EQUAL( p->continuity_counter(), 0x0eu ); } ///////////////////////////////cc.e//////////////////////////////////////// diff --git a/Socket/Protocols/DVB/DVBDemuxSocketProtocol.hh b/Socket/Protocols/DVB/DVBDemuxSocketProtocol.hh index e5963e911853ce23e5ae85aeab63d91ae329392a..75450225b3789ed3dd542e7ca3357a8aa70ef1aa 100644 --- a/Socket/Protocols/DVB/DVBDemuxSocketProtocol.hh +++ b/Socket/Protocols/DVB/DVBDemuxSocketProtocol.hh @@ -39,14 +39,18 @@ namespace senf { /// \addtogroup protocol_facets_group /// @{ - /** xxx + /** \todo Document me! */ class DVBDemuxSocketProtocol : public virtual SocketProtocol { public: - void setBufferSize(unsigned long size) const; - + void setBufferSize(unsigned long size) const; + ///< set the size of the circular buffer used for filtered data. + /**< The default size is two maximum sized sections, i.e. if this + function is not called a buffer size of 2 * 4096 bytes will + be used. + \param[in] size Size of circular buffer. */ void startFiltering() const; void stopFiltering() const; diff --git a/Socket/Protocols/UN/ConnectedUNDatagramSocketHandle.cc b/Socket/Protocols/UN/ConnectedUNDatagramSocketHandle.cc index 2a9a4db50c826300e78ef0c662a0f436d54eaea4..21e7ddce76efece394ba7f66cf1455e5f6b28ea1 100644 --- a/Socket/Protocols/UN/ConnectedUNDatagramSocketHandle.cc +++ b/Socket/Protocols/UN/ConnectedUNDatagramSocketHandle.cc @@ -38,10 +38,10 @@ prefix_ void senf::ConnectedUNDatagramSocketProtocol::init_client() const { - int sock = ::socket(PF_UNIX,SOCK_DGRAM,0); + int sock = ::socket(PF_UNIX, SOCK_DGRAM, 0); if (sock < 0) throw SystemException( "Could not create socket(PF_UNIX,SOCK_DGRAM,0)." ); - fd(sock); + fd(sock); } prefix_ void senf::ConnectedUNDatagramSocketProtocol::init_client(UNSocketAddress const & address) const diff --git a/Utils/Logger/IOStreamTarget.cc b/Utils/Logger/IOStreamTarget.cc index 6d720b56327c89170e2ffccea23f829f1bf579f8..dbf4454fcfa6e77e512295ec39342fb6d29ecfc6 100644 --- a/Utils/Logger/IOStreamTarget.cc +++ b/Utils/Logger/IOStreamTarget.cc @@ -71,9 +71,9 @@ prefix_ void senf::log::IOStreamTarget::v_write(boost::posix_time::ptime timesta for (; i != i_end; ++i) { stream_ << timestamp << sep; + stream_ << "[" << LEVELNAMES_[level] << "]"; if (area != "senf::log::DefaultArea") - stream_ << "[" << area << "]"; - stream_ << "[" << LEVELNAMES_[level] << "] "; + stream_ << "[" << area << "] "; stream_ << *i << "\n"; sep = '-'; }