Skip to content
Snippets Groups Projects
Unverified Commit 381aa429 authored by Mashiro's avatar Mashiro Committed by GitHub
Browse files

[Fix] Make default scope of runner be `mmengine` (#435)

* make default scope of runner be mmengine

* fix as comment
parent ac8686e2
No related branches found
No related tags found
No related merge requests found
...@@ -32,6 +32,9 @@ class DefaultScope(ManagerMixin): ...@@ -32,6 +32,9 @@ class DefaultScope(ManagerMixin):
def __init__(self, name: str, scope_name: str): def __init__(self, name: str, scope_name: str):
super().__init__(name) super().__init__(name)
assert isinstance(
scope_name,
str), (f'scope_name should be a string, but got {scope_name}')
self._scope_name = scope_name self._scope_name = scope_name
@property @property
......
...@@ -164,8 +164,8 @@ class Runner: ...@@ -164,8 +164,8 @@ class Runner:
visualizer (Visualizer or dict, optional): A Visualizer object or a visualizer (Visualizer or dict, optional): A Visualizer object or a
dict build Visualizer object. Defaults to None. If not dict build Visualizer object. Defaults to None. If not
specified, default config will be used. specified, default config will be used.
default_scope (str, optional): Used to reset registries location. default_scope (str): Used to reset registries location.
Defaults to None. Defaults to "mmengine".
randomness (dict): Some settings to make the experiment as reproducible randomness (dict): Some settings to make the experiment as reproducible
as possible like seed and deterministic. as possible like seed and deterministic.
Defaults to ``dict(seed=None)``. If seed is None, a random number Defaults to ``dict(seed=None)``. If seed is None, a random number
...@@ -257,7 +257,7 @@ class Runner: ...@@ -257,7 +257,7 @@ class Runner:
log_processor: Optional[Dict] = None, log_processor: Optional[Dict] = None,
log_level: str = 'INFO', log_level: str = 'INFO',
visualizer: Optional[Union[Visualizer, Dict]] = None, visualizer: Optional[Union[Visualizer, Dict]] = None,
default_scope: Optional[str] = None, default_scope: str = 'mmengine',
randomness: Dict = dict(seed=None), randomness: Dict = dict(seed=None),
experiment_name: Optional[str] = None, experiment_name: Optional[str] = None,
cfg: Optional[ConfigType] = None, cfg: Optional[ConfigType] = None,
...@@ -452,7 +452,7 @@ class Runner: ...@@ -452,7 +452,7 @@ class Runner:
log_processor=cfg.get('log_processor'), log_processor=cfg.get('log_processor'),
log_level=cfg.get('log_level', 'INFO'), log_level=cfg.get('log_level', 'INFO'),
visualizer=cfg.get('visualizer'), visualizer=cfg.get('visualizer'),
default_scope=cfg.get('default_scope'), default_scope=cfg.get('default_scope', 'mmengine'),
randomness=cfg.get('randomness', dict(seed=None)), randomness=cfg.get('randomness', dict(seed=None)),
experiment_name=cfg.get('experiment_name'), experiment_name=cfg.get('experiment_name'),
cfg=cfg, cfg=cfg,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment