Skip to content
Snippets Groups Projects
Commit 34f0baba authored by Stefano Borini's avatar Stefano Borini
Browse files

Removed the workaround as we are using a different strategy with the id

parent 8ad0a7de
No related branches found
No related tags found
1 merge request!130Safer plugin import - 2
......@@ -40,10 +40,10 @@ class BaseExtensionPlugin(Plugin):
#: Reports if the plugin loaded its factories successfully or not.
broken = Bool(False)
#: The error that have been generated by the instantiations.
#: The error message generated by the factory instantiations
error_msg = Unicode()
#: The error that have been generated by the instantiations.
#: The error traceback generated by the factory instantiations.
error_tb = Unicode()
#: A list of all the factory classes to export.
......@@ -122,10 +122,5 @@ class BaseExtensionPlugin(Plugin):
"""Returns all the factories of the given type"""
return [cls for cls in self.factory_classes if issubclass(cls, type_)]
def _id_default(self):
"""Override for base method that raises a warning we don't want to
show"""
return '%s.%s' % (type(self).__module__, type(self).__name__)
def __logger_default(self):
return logging.getLogger(self.__class__.__name__)
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment