Removed now useless checks as they are checked via traits
Created by: stefanoborini
Fixes #136 (closed) by rephrasing the issue. The point is that we don't need the check as we are guaranteed by initialization that the class will contain something that satisfies the trait, that is, it will not be None due to the allow_none=False option. if the get_ methods are not redefined to return something, they will raise a NotImplementedError which is self-describing. If the trait is assigned something it doesn't like it will also report a meaningful error message.
Merge request reports
Activity
Created by: codecov[bot]
Codecov Report
Merging #143 into master will increase coverage by
1.48%
. The diff coverage isn/a
.@@ Coverage Diff @@ ## master #143 +/- ## ========================================== + Coverage 89.69% 91.18% +1.48% ========================================== Files 37 37 Lines 980 964 -16 Branches 77 73 -4 ========================================== Hits 879 879 + Misses 92 80 -12 + Partials 9 5 -4
Impacted Files Coverage Δ force_bdss/ui_hooks/base_ui_hooks_factory.py 100% <ø> (+12.12%)
force_bdss/mco/base_mco_factory.py 100% <ø> (+21.42%)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 37ffc20...1031ed7. Read the comment docs.