Verifier Additions
Created by: jjenthought
Just adds a check for kpis, since they got moved to the mco. Also adds the layer a datasource occupies as part of the error message
Merge request reports
Activity
Filter activity
Created by: codecov[bot]
Codecov Report
Merging #163 into master will increase coverage by
0.24%
. The diff coverage is100%
.@@ Coverage Diff @@ ## master #163 +/- ## ========================================== + Coverage 92.8% 93.05% +0.24% ========================================== Files 42 42 Lines 987 993 +6 Branches 70 73 +3 ========================================== + Hits 916 924 +8 + Misses 68 67 -1 + Partials 3 2 -1
Impacted Files Coverage Δ force_bdss/core/kpi_specification.py 100% <100%> (ø)
force_bdss/core/verifier.py 91.04% <100%> (+4.15%)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 82dffe0...1793389. Read the comment docs.43 42 errors.append(VerifierError(subject=param, 44 error="Parameter has empty name")) 43 error="Parameter {} ({}) has empty " 44 "name".format(idx, p_name))) 45 45 if len(param.type.strip()) == 0: 46 46 errors.append(VerifierError(subject=param, 47 error="Parameter has empty type")) 47 error="Parameter {} ({}) has empty " 48 "type".format(idx, p_name))) 49 50 for idx, kpi in enumerate(mco.kpis): 51 if len(kpi.name.strip()) == 0: 52 errors.append(VerifierError(subject=kpi, 53 error="KPI {} has empty name".format( 54 idx))) 55 if kpi.objective == '':
Please register or sign in to reply