Skip to content
Snippets Groups Projects

Verifier Additions

Merged Verifier Additions
verifier-addition into master
Merged Adham Hashibon requested to merge verifier-addition into master

Created by: jjenthought

Just adds a check for kpis, since they got moved to the mco. Also adds the layer a datasource occupies as part of the error message

Merge request reports

Approval is optional
Ready to merge by members who can write to the target branch.

Merge details

  • 3 commits and 1 merge commit will be added to master.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Adham Hashibon
  • Adham Hashibon
  • Adham Hashibon
  • Adham Hashibon
  • Adham Hashibon
    Adham Hashibon @has started a thread on commit 1793389a
    • force_bdss/core/verifier.py
    43 42 errors.append(VerifierError(subject=param,
    44 error="Parameter has empty name"))
    43 error="Parameter {} ({}) has empty "
    44 "name".format(idx, p_name)))
    45 45 if len(param.type.strip()) == 0:
    46 46 errors.append(VerifierError(subject=param,
    47 error="Parameter has empty type"))
    47 error="Parameter {} ({}) has empty "
    48 "type".format(idx, p_name)))
    49
    50 for idx, kpi in enumerate(mco.kpis):
    51 if len(kpi.name.strip()) == 0:
    52 errors.append(VerifierError(subject=kpi,
    53 error="KPI {} has empty name".format(
    54 idx)))
    55 if kpi.objective == '':
    • Adham Hashibon
      Adham Hashibon @has ·
      Author Owner

      Created by: stefanoborini

      This technically cannot happen unless we add the empty option to the objective. I am conflicted if we should provide one or not, you made a good point about adding it though... I'd suggest to add it to the enumeration as well, in first position.

  • Adham Hashibon
    Adham Hashibon @has ·
    Author Owner

    Created by: stefanoborini

    Minor thing and coverage as a consequence about the option of having '' as a kpi option. I'd say go for it.

  • Adham Hashibon
  • Adham Hashibon
    • Please register or sign in to reply

    Datenschutz und Impressum