Skip to content
Snippets Groups Projects
  1. Jan 13, 2020
  2. Jan 09, 2020
  3. Jan 08, 2020
  4. Jan 07, 2020
  5. Dec 17, 2019
    • Jerome Forissier's avatar
      hikey960: fix EDK2 build with GCC 9.x · 1e8d0b5a
      Jerome Forissier authored
      The current EDK2 code fails to build with GCC 9.x:
      
       make[3]: Entering directory '/home/jerome/work/optee_repo_hikey960/edk2/BaseTools/Source/C/GenVtf'
       gcc  -c -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-unused-result -nostdlib -c -g  -I .. -I ../Include/Common -I ../Include/ -I ../Include/IndustryStandard -I ../Common/ -I .. -I . -I ../Include/X64/  -O2 GenVtf.c -o GenVtf.o
       In file included from /usr/include/string.h:494,
                        from ../Common/FvLib.h:21,
                        from GenVtf.c:19:
       In function ‘strncpy’,
           inlined from ‘ConvertVersionInfo’ at GenVtf.c:132:7:
       /usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
         106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
             |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       GenVtf.c: In function ‘ConvertVersionInfo’:
       GenVtf.c:130:14: note: length computed here
         130 |     Length = strlen(Str);
             |              ^~~~~~~~~~~
       In file included from /usr/include/string.h:494,
                        from ../Common/FvLib.h:21,
                        from GenVtf.c:19:
       In function ‘strncpy’,
           inlined from ‘CreateFitTableAndInitialize’ at GenVtf.c:1532:3:
       /usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
         106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
             |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       cc1: all warnings being treated as errors
       make[3]: *** [../Makefiles/footer.makefile:27: GenVtf.o] Error 1
      
      This error was found with Ubuntu 19.10 (comes with GCC 9.2.1).
      
      The HiKey960 EDK2 repository [1] has not received any update in the
      past year, I am not sure it is still maintained. There is apparently
      some support for HiKey960 in the upstream EDK2 repositories [2] and
      [3], but I could not get my board to boot with upstream code.
      
      So, a quick fix seems in order.
      
      [1] https://github.com/96boards-hikey/edk2.git
      [2] https://github.com/tianocore/edk2.git
      [3] https://github.com/tianocore/edk2-platforms.git
      
      
      
      Signed-off-by: default avatarJerome Forissier <jerome@forissier.org>
      Acked-by: default avatarVictor Chong <victor.chong@linaro.org>
      1e8d0b5a
  6. Nov 22, 2019
  7. Nov 08, 2019
  8. Oct 11, 2019
  9. Oct 10, 2019
  10. Oct 09, 2019
  11. Oct 08, 2019
  12. Oct 07, 2019
  13. Sep 10, 2019
  14. Sep 04, 2019
    • Jerome Forissier's avatar
      common.mk: buildroot: append BR2_ variables to config automatically · 7fbd6ce2
      Jerome Forissier authored
      
      To set additional BR2_ variables, the user currently needs to edit
      common.mk and modify the buildroot recipe. It is inconvenient,
      especially since a line with a cumbersome syntax has to be added. One
      would expect to be able to specify the desired value on the make
      command line or directly in the Makefile. For instance, to enable
      debug mode: make BR2_ENABLE_DEBUG=y.
      
      This patch updates the buildroot recipe to enumerate all the Makefile
      variables that start with BR2_, and each such variable is automatically
      added to ../out-br/extra.conf.
      
      As a result the existing BR2_ variables can be set in a simpler way.
      
      Tested on QEMU, results in the same ../out-br/.config except for the
      line order.
      
      Signed-off-by: default avatarJerome Forissier <jerome@forissier.org>
      Suggested-by: default avatarHeino Madsen <heino.madsen@huawei.com>
      Reviewed-by: default avatarJens Wiklander <jens.wiklander@linaro.org>
      7fbd6ce2
  15. Aug 13, 2019
  16. Aug 07, 2019
  17. Jun 28, 2019
  18. Jun 11, 2019
  19. Jun 03, 2019
  20. May 23, 2019
    • Joakim Bech's avatar
      buildroot: Update toolchain and kernel headers · 6e167bf1
      Joakim Bech authored
      
      The BR2_KERNEL_HEADERS_4_10 has been depracted, so when trying to build
      with GDBSERVER=y we got this warning:
      
        Makefile.legacy:9: *** "You have legacy configuration in your .config!
        Please check your configuration.".  Stop.
      
      To better match recent toolchain updates in this git (gcc updates and
      kernel header updates, commit e0298161), we also update buildroot to
      use and provide a GCC8.x based toolchain as well as 4.19 kernel headers.
      
      Signed-off-by: default avatarJoakim Bech <joakim.bech@linaro.org>
      Tested-by: Joakim Bech <joakim.bech@linaro.org> (QEMU v7)
      Acked-by: default avatarJerome Forissier <jerome@forissier.org>
      6e167bf1
  21. May 18, 2019
    • Joakim Bech's avatar
      toolchain: Update to GCC 8.3 and update kernel headers · e0298161
      Joakim Bech authored
      
      In the GCC v8.2-2018.08 toolchain (previous default in OP-TEE) the
      GDB/TUI mode was disabled, which made debugging using GDB slightly more
      complicated. However, in more recent versions of GCC like the one
      introduced here, i.e., GCC8.3-2019.03, Arm have re-enabled the TUI mode.
      
      But to be able to upgrade the toolchain, one must also step up kernel
      headers so that the toolchain matches the kernel headers used by
      Buildroot. This means that we are stepping up from 4.18 kernel headers
      to 4.19 kernel headers, which seems to be compatible with the version of
      GCC that is being introduced in this patch.
      
      Note that after this commit, older GCC versions will not work any
      longer when building full OP-TEE developer setups using OP-TEE's
      manifest.git and build.git, i.e., trying to run GCC8.2 for example will
      give a kernel header mismatch error.
      
      Fixes #334.
      
      Signed-off-by: default avatarJoakim Bech <joakim.bech@linaro.org>
      Tested-by: Joakim Bech <joakim.bech@linaro.org> (QEMU v7, v8)
      Acked-by: default avatarJerome Forissier <jerome.forissier@linaro.org>
      e0298161
  22. May 13, 2019
Loading