Skip to content
Snippets Groups Projects
  1. Jan 11, 2022
  2. Jan 05, 2022
  3. Jan 03, 2022
  4. Dec 22, 2021
  5. Dec 21, 2021
    • Joakim Bech's avatar
      GitHub actions: General updates · fb0071bb
      Joakim Bech authored
      
      - Update 'stale' from v1.0 to v4.0.1.
      - Give 'write' permissions to actions (pull requests and issues).
      - Add 'enhancement' to 'exempt-issue-label', so we that stale doesn't
        automatically close issues and pr's with the 'enhancement' label.
      - Add 'exempt-pr-label' to match exempt-issue-label'.
      - Add and set (to true)
          remove-issue-stale-when-updated
          remove-pr-stale-when-updated
        which will automatically remove the 'Stale' label when someone adds a
        new comment to a ticket marked as stale.
      
      Signed-off-by: default avatarJoakim Bech <joakim.bech@linaro.org>
      Acked-by: default avatarJens Wiklander <jens.wiklander@linaro.org>
      fb0071bb
  6. Nov 04, 2021
  7. Oct 19, 2021
    • Jerome Forissier's avatar
      buildroot: Update toolchain when GDBSERVER=y · 9eccdd56
      Jerome Forissier authored
      Fix the following build error:
      
       $ make GDBSERVER=y
       ...
       Makefile.legacy:9: *** "You have legacy configuration in your .config! Please check your configuration.".  Stop.
      
      The error was introduced by the upgrade to Buildroot 2021.08 [1].
      
      The deprecated option can be found by running "make menuconfig" in
      out-br/ and checking the "Legacy options" submenu. It shows that
      "gcc 8.x support removed" is selected. We can also see that
      BR2_GCC_VERSION_8_X=y appears just below the comment "Legacy options
      removed in 2021.08" in out-br/.config. This options comes from file
      br-ext/configs/toolchain-br.
      
      Upgrade the toolchain to 10.x which is available in Buildroot 2021.08
      and corresponds to the pre-built version we use by default ("make
      toolchains" currently downloads 10.2).
      
      Link: https://github.com/OP-TEE/manifest/commit/e8d2210
      
      
      Signed-off-by: default avatarJerome Forissier <jerome@forissier.org>
      Reviewed-by: default avatarJoakim Bech <joakim.bech@linaro.org>
      9eccdd56
  8. Oct 18, 2021
  9. Oct 04, 2021
  10. Oct 01, 2021
    • Jerome Forissier's avatar
      optee_rust_examples_ext.mk: remove extra space in PATH · c4d80a6c
      Jerome Forissier authored
      
      When upgrading from Buildroot 2021.2 to 2021.08, the following error
      occurs:
      
       $ make buildroot
       ...
         GEN     /home/jerome/work/optee_repo_qemu_v8/out-br/Makefile
      
       Your PATH contains spaces, TABs, and/or newline (\n) characters.
       This doesn't work. Fix you PATH.
       make[1]: *** [Makefile:23: _all] Error 2
       make[1]: Leaving directory '/home/jerome/work/optee_repo_qemu_v8/out-br'
       make: *** [common.mk:323: buildroot] Error 2
      
      The space comes from the line that appends the toolchain to the PATH in
      optee_rust_examples_ext.mk. Fix it.
      
      Signed-off-by: default avatarJerome Forissier <jerome@forissier.org>
      c4d80a6c
  11. Sep 30, 2021
  12. Sep 20, 2021
    • Ibai Erkiaga's avatar
      zynqmp: initial non petalinux based build · 236a7812
      Ibai Erkiaga authored
      
      Current ZynqMP build script is based on Xilinx Petalinux tool, which
      requires the installation of a proprietary tool. The following patch
      removes this dependency and gets closed to the common build Makefile
      used by other platforms.
      
      The build is done using Xilinx out-of-tree repositories for Linux,
      U-Boot and ATF, while using upstream OP-TEE and Buildroot repositories.
      
      Finally the only non standard piece is the usage of pre-compiled
      firmware images from the Xilinx wiki page.
      
      Signed-off-by: default avatarIbai Erkiaga <ibai.erkiaga-elorza@xilinx.com>
      Acked-by: default avatarJerome Forissier <jerome@forissier.org>
      236a7812
  13. Sep 15, 2021
  14. Sep 08, 2021
  15. Aug 31, 2021
    • Jerome Forissier's avatar
      qemu: do not force kernel CONFIG_PREEMPT=y · db215798
      Jerome Forissier authored
      
      Since Linux commit dcb3b06d9c34 ("tee: optee: replace might_sleep with
      cond_resched") in v5.11, setting CONFIG_PREEMPT=y in kconfigs/qemu.conf
      is not needed anymore. It was a workaround for the missing call to
      cond_resched() in the TEE driver. At that time, might_sleep() together
      with preemption enabled allowed to get rid of some RCU warning messages
      when running long operations in secure world such as large key generation
      (test case: "xtest -l 1 4007_rsa"). With cond_resched() the preemption
      settings do not matter anymore.
      
      As a result of this change, QEMUv8 is unmodified (CONFIG_PREEMPT=y is
      set by default in the kernel's arch/arm64/configs/defconfig), but 32-bit
      QEMU now has CONFIG_PREEMPT disabled. Both platforms are tested and
      4007_rsa runs as expected with no warning.
      
      Signed-off-by: default avatarJerome Forissier <jerome@forissier.org>
      Acked-by: default avatarJens Wiklander <jens.wiklander@linaro.org>
      Acked-by: default avatarEtienne Carriere <etienne.carriere@linaro.org>
      db215798
    • Ibai Erkiaga's avatar
      linux-defconfig: explicit cross compile flag usage · 264c7d47
      Ibai Erkiaga authored
      
      Current linux config file generation does not add the cross compilation
      flag, leading potentially to compilation errors. Not sure how a proper config
      file is generated with current implementation but issues are observerd
      specially when buildling the linux image with a single thread.
      
      This commit ensures that both ARCH and CROSS_COMPILE flags are set when
      using the merge_config script.
      
      Signed-off-by: default avatarIbai Erkiaga <ibai.erkiaga-elorza@xilinx.com>
      Reviewed-by: default avatarJerome Forissier <jerome@forissier.org>
      264c7d47
  16. Aug 24, 2021
  17. Aug 12, 2021
  18. Aug 05, 2021
  19. Jul 13, 2021
    • Jerome Forissier's avatar
      hikey: fix 'invalid partition' error during recovery · 4a5b6176
      Jerome Forissier authored
      After trying to use upstream EDK2 on my HiKey board without success,
      I reached a point where even 'make recovery' would not make the board
      bootable again. The recovery process failed like so:
      
       $ make recovery
       [...]
       Waiting for device... [35][34][33][32][31][30][29][28][27][26][25][24][23][22][21][20][19][18]
       Sending /home/jerome/work/optee_repo_hikey/build/../l-loader/recovery.bin ...
       Done
      
       fastboot flash loader /home/jerome/work/optee_repo_hikey/build/../l-loader/l-loader.bin
       < waiting for any device >
       Sending 'loader' (39 KB)                           FAILED (remote: 'invalid partition')
       fastboot: error: Command failed
       make: *** [Makefile:351: recovery] Error 1
      
      The solution to this problem is mentioned in [1] and consists in
      running 'fastboot getvar partition-size:ptable' before the fastboot
      flash command.
      
      Link: [1] https://github.com/96boards/documentation/issues/751
      
      .
      Signed-off-by: default avatarJerome Forissier <jerome@forissier.org>
      Acked-by: default avatarVictor Chong <victor.chong@linaro.org>
      3.14.0
      4a5b6176
  20. Jul 06, 2021
  21. Jul 01, 2021
    • Jens Wiklander's avatar
      qemu_v8: xen: replace virt-make-fs with mke2fs · fc2747c2
      Jens Wiklander authored
      
      Replaces virt-make-fs with mke2fs since it's more robust on Ubuntu and
      also a bit faster.
      
      Fixes build problems like:
      virt-make-fs -t ext4
      /home/jens/work/repos/qemu_v8_xen/build/../out/bin/xen_files
      /home/jens/work/repos/qemu_v8_xen/build/../out/bin/xen.ext4
      Image Name:   Root file system
      Created:      Wed Jun 30 19:34:06 2021
      Image Type:   AArch64 Linux RAMDisk Image (gzip compressed)
      Data Size:    31978230 Bytes = 31228.74 KiB = 30.50 MiB
      Load Address: 44000000
      Entry Point:  44000000
      libguestfs: error: tar_in: tar subcommand failed on directory: /: tar:
      ./rootfs.cpio.gz: Wrote only 6144 of 10240 bytes
      tar: Exiting with failure status due to previous errors
      make: *** [Makefile:362: xen-create-image] Error 1
      
      Reviewed-by: default avatarJerome Forissier <jerome@forissier.org>
      Tested-by: default avatarJerome Forissier <jerome@forissier.org>
      Signed-off-by: default avatarJens Wiklander <jens.wiklander@linaro.org>
      fc2747c2
  22. Jun 30, 2021
  23. Jun 29, 2021
  24. Jun 28, 2021
    • Jerome Forissier's avatar
      qemu_v8.mk: xen: pass -t ext4 instead of -t vfat to make-virt-fs · 271ecf35
      Jerome Forissier authored
      
      make-virt-fs is used to generate xen.ext4 but is passed '-t vfat'
      instead of '-t ext4'. Fix that.
      
      In fact '-t vfat' happens to be working in general, presumably because
      the actual format of the image is detected at runtime. However, I could
      not manage to make a VFAT image work in a Docker container based on
      Ubuntu 21.04 and with the following kernel image package installed:
      
        linux-image-kvm/hirsute-updates,now 5.11.0.1009.9 amd64 [installed]
      
      The error messages are as follows:
      
      root@32b61ad4d7f3:~/optee_repo_qemu_v8/build# LIBGUESTFS_DEBUG=1 LIBGUESTFS_TRACE=1 virt-make-fs -t vfat /root/optee_repo_qemu_v8/build/../out/bin/xen_files /root/optee_repo_qemu_v8/build/../out/bin/xen.ext4
      [...]
      libguestfs: trace: mount_options "utf8" "/dev/sda" "/"
      guestfsd: => mkfs (0x116) took 0.47 secs
      guestfsd: <= mount_options (0x4a) request length 68 bytes
      commandrvf: stdout=n stderr=y flags=0x0
      commandrvf: udevadm --debug settle -E /dev/sda
      SELinux enabled state cached to: disabled
      No filesystem is currently mounted on /sys/fs/cgroup.
      Failed to determine unit we run in, ignoring: No data available
      command: mount '-o' 'utf8' '/dev/sda' '/sysroot//'
      [   11.673076] squashfs: Unknown parameter 'utf8'
      [   11.694908] fuseblk: Unknown parameter 'utf8'
      command: mount returned 32
      command: mount: stderr:
      mount: /sysroot: wrong fs type, bad option, bad superblock on /dev/sda, missing codepage or helper program, or other error.
      ocaml_exn: 'mount_options' raised 'Failure' exception
      guestfsd: error: mount exited with status 32: mount: /sysroot: wrong fs type, bad option, bad superblock on /dev/sda, missing codepage or helper program, or other error.
      guestfsd: => mount_options (0x4a) took 0.40 secs
      libguestfs: trace: mount_options = -1 (error)
      libguestfs: error: mount_options: mount exited with status 32: mount: /sysroot: wrong fs type, bad option, bad superblock on /dev/sda, missing codepage or helper program, or other error.
      libguestfs: trace: close
      libguestfs: closing guestfs handle 0x55f423503430 (state 2)
      [...]
      
      With '-t ext4', the issue is gone.
      
      Signed-off-by: default avatarJerome Forissier <jerome@forissier.org>
      Acked-by: default avatarJens Wiklander <jens.wiklander@linaro.org>
      Acked-by: default avatarRuchika Gupta <ruchika.gupta@linaro.org>
      271ecf35
    • Jerome Forissier's avatar
      github: update links in issue/PR templates · 89302b9e
      Jerome Forissier authored
      
      Update broken URLs in the issue and PR templates.
      
      Signed-off-by: default avatarJerome Forissier <jerome@forissier.org>
      Reviewed-by: default avatarJoakim Bech <joakim.bech@linaro.org>
      Reviewed-by: default avatarJens Wiklander <jens.wiklander@linaro.org>
      89302b9e
  25. Jun 25, 2021
  26. Jun 24, 2021
Loading