Simplify ALlIncludesHH usage

Fix python imports in SConscripts

PPI/SConscript

@@ -7,9 +7,7 @@ import SENFSCons, glob
 
 SConscript(glob.glob("*/SConscript"))
 
-SENFSCons.AllIncludesHH(env, [ f for f in glob.glob("*.hh")
-                               if f not in ('all_includes.hh','PPI.hh') \
-                                  and not f.endswith('.test.hh') ])
+SENFSCons.AllIncludesHH(env, exclude = ['PPI.hh'])
 
 sources, tests, includes = SENFSCons.Glob(env, subdirs=[ 'detail' ])
 

SConstruct

 # -*- python -*-
 
-import sys, glob, os.path, datetime, pwd, time, fnmatch, string
+import sys, glob, os.path, fnmatch
 sys.path.append(Dir('#/senfscons').abspath)
 sys.path.append(Dir('#/doclib').abspath)
 import SENFSCons, senfutil
@@ -172,7 +172,7 @@ env.PhonyTarget('valgrind', [ 'all_tests' ], [ """
 #### clean
 env.Clean('all', '.prepare-stamp')
 env.Clean('all', libsenf)
-env.Clean('all', 'linklint')
+env.Clean('all', env.Dir('linklint')) # env.Dir to disambiguate from linklint PhonyTarget
 
 if env.GetOption('clean'):
     env.Clean('all', [ os.path.join(path,f)

Socket/Protocols/DVB/SConscript

@@ -7,8 +7,7 @@ import SENFSCons, glob
 
 SConscript(glob.glob("*/SConscript"))
 
-SENFSCons.AllIncludesHH(env, [ f for f in glob.glob("*.hh")
-                               if f not in ('all_includes.hh','DVB.hh') and not f.endswith('.test.hh') ])
+SENFSCons.AllIncludesHH(env, exclude=['DVB.hh'])
 
 sources, tests, includes = SENFSCons.Glob(env)
 

Socket/Protocols/INet/SConscript

@@ -7,8 +7,7 @@ import SENFSCons, glob
 
 SConscript(glob.glob("*/SConscript"))
 
-SENFSCons.AllIncludesHH(env, [ f for f in glob.glob("*.hh")
-                               if f not in ('all_includes.hh','INet.hh') and not f.endswith('.test.hh') ])
+SENFSCons.AllIncludesHH(env, exclude=['INet.hh'])
 
 sources, tests, includes = SENFSCons.Glob(env)
 

Socket/Protocols/Raw/SConscript

@@ -7,8 +7,7 @@ import SENFSCons, glob
 
 SConscript(glob.glob("*/SConscript"))
 
-SENFSCons.AllIncludesHH(env, [ f for f in glob.glob("*.hh")
-                               if f not in ('all_includes.hh','Raw.hh') and not f.endswith('.test.hh') ])
+SENFSCons.AllIncludesHH(env, exclude=['Raw.hh'])
 
 sources, tests, includes = SENFSCons.Glob(env)
 

Socket/Protocols/UN/SConscript

@@ -7,8 +7,7 @@ import SENFSCons, glob
 
 SConscript(glob.glob("*/SConscript"))
 
-SENFSCons.AllIncludesHH(env, [ f for f in glob.glob("*.hh")
-                               if f not in ('all_includes.hh','UN.hh') and not f.endswith('.test.hh') ])
+SENFSCons.AllIncludesHH(env, exclude=['UN.hh'])
 
 sources, tests, includes = SENFSCons.Glob(env)
 

Socket/SConscript

@@ -7,8 +7,7 @@ import SENFSCons, glob
 
 SConscript(glob.glob("*/SConscript"))
 
-SENFSCons.AllIncludesHH(env, [ f for f in glob.glob("*.hh")
-                               if f not in ('all_includes.hh','Socket.hh') and not f.endswith('.test.hh') ])
+SENFSCons.AllIncludesHH(env, exclude=['Socket.hh'])
 
 sources, tests, includes = SENFSCons.Glob(env)
 

Utils/Logger/SConscript

@@ -5,9 +5,7 @@ import SENFSCons, glob
 
 ###########################################################################
 
-SENFSCons.AllIncludesHH(env, [ f for f in glob.glob("*.hh")
-                               if ( f not in ('all_includes.hh','Logger.hh','SenfLog.hh')
-                                    and not f.endswith('.test.hh') ) ])
+SENFSCons.AllIncludesHH(env, exclude=['Logger.hh','SenfLog.hh'])
 
 sources, tests, includes = SENFSCons.Glob(env)
 

Utils/Termlib/SConscript

@@ -11,4 +11,4 @@ env.Append(ALLOBJECTS = env.Object(sources))
 env.BoostUnitTest('test', tests)
 SENFSCons.Doxygen(env)
 env.InstallSubdir('$INCLUDEINSTALLDIR', includes)
-env.Program('telnetSserver', ['telnetServer.cc'])
+env.Program('telnetServer', ['telnetServer.cc'])

debian/SConscript

 # -*- python -*-
 
 Import('env')
-import SENFSCons, os
+import SENFSCons, os, os.path, pwd, time, string
 
 ###########################################################################
 

senfscons/SENFSCons.py

@@ -79,7 +79,10 @@ def Doxygen(env, doxyfile = "Doxyfile", extra_sources = []):
 
     return doc
 
-def AllIncludesHH(env, headers):
+def AllIncludesHH(env, exclude=[]):
+    exclude = exclude[:] + ['all_includes.hh'] # Make a copy !!
+    headers = [ f for f in glob.glob("*.hh")
+                if f not in exclude and not f.endswith('.test.hh') ]
     headers.sort()
     target = env.File("all_includes.hh")
     file(target.abspath,"w").write("".join([ '#include "%s"\n' % f