Skip to content
Snippets Groups Projects
Commit 1031ed71 authored by Stefano Borini's avatar Stefano Borini
Browse files

Removed now useless checks as they are checked via traits

parent 37ffc206
No related branches found
No related tags found
1 merge request!143Removed now useless checks as they are checked via traits
...@@ -92,13 +92,6 @@ class BaseMCOFactory(HasStrictTraits): ...@@ -92,13 +92,6 @@ class BaseMCOFactory(HasStrictTraits):
BaseMCO BaseMCO
The optimizer The optimizer
""" """
if self.optimizer_class is None:
msg = ("optimizer_class cannot be None in {}. Either define "
"optimizer_class or reimplement create_optimizer on "
"your factory class.".format(self.__class__.__name__))
log.error(msg)
raise RuntimeError(msg)
return self.optimizer_class(self) return self.optimizer_class(self)
def create_model(self, model_data=None): def create_model(self, model_data=None):
...@@ -122,13 +115,6 @@ class BaseMCOFactory(HasStrictTraits): ...@@ -122,13 +115,6 @@ class BaseMCOFactory(HasStrictTraits):
if model_data is None: if model_data is None:
model_data = {} model_data = {}
if self.model_class is None:
msg = ("model_class cannot be None in {}. Either define "
"model_class or reimplement create_model on your "
"factory class.".format(self.__class__.__name__))
log.error(msg)
raise RuntimeError(msg)
return self.model_class(self, **model_data) return self.model_class(self, **model_data)
def create_communicator(self): def create_communicator(self):
...@@ -140,13 +126,6 @@ class BaseMCOFactory(HasStrictTraits): ...@@ -140,13 +126,6 @@ class BaseMCOFactory(HasStrictTraits):
BaseMCOCommunicator BaseMCOCommunicator
An instance of the communicator An instance of the communicator
""" """
if self.communicator_class is None:
msg = ("communicator_class cannot be None in {}. Either define "
"communicator_class or reimplement create_communicator on "
"your factory class.".format(self.__class__.__name__))
log.error(msg)
raise RuntimeError(msg)
return self.communicator_class(self) return self.communicator_class(self)
def parameter_factories(self): def parameter_factories(self):
......
...@@ -79,12 +79,4 @@ class BaseUIHooksFactory(HasStrictTraits): ...@@ -79,12 +79,4 @@ class BaseUIHooksFactory(HasStrictTraits):
------- -------
BaseUIHooksManager BaseUIHooksManager
""" """
if self.ui_hooks_manager_class is None:
msg = ("ui_hooks_manager_class cannot be None in {}. Either "
"define ui_hooks_manager_class or reimplement "
"create_ui_hooks_manager on "
"your factory class.".format(self.__class__.__name__))
log.error(msg)
raise RuntimeError(msg)
return self.ui_hooks_manager_class(self) return self.ui_hooks_manager_class(self)
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment