Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
F
force-bdss
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Adham Hashibon
force-bdss
Commits
b73dfdda
Commit
b73dfdda
authored
6 years ago
by
James Johnson
Browse files
Options
Downloads
Patches
Plain Diff
variable naming, more descriptive errors
parent
b3319f89
No related branches found
No related tags found
1 merge request
!163
Verifier Additions
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
force_bdss/core/verifier.py
+15
-10
15 additions, 10 deletions
force_bdss/core/verifier.py
with
15 additions
and
10 deletions
force_bdss/core/verifier.py
+
15
−
10
View file @
b73dfdda
...
...
@@ -37,21 +37,22 @@ def _check_mco(workflow):
error
=
"
MCO has no defined parameters
"
))
for
idx
,
param
in
enumerate
(
mco
.
parameters
):
p_name
=
param
.
factory
.
name
if
len
(
param
.
name
.
strip
())
==
0
:
errors
.
append
(
VerifierError
(
subject
=
param
,
error
=
"
Parameter {}
"
"
has empty
name
"
.
format
(
idx
)))
error
=
"
Parameter {}
({}) has empty
"
"
name
"
.
format
(
idx
,
p_name
)))
if
len
(
param
.
type
.
strip
())
==
0
:
errors
.
append
(
VerifierError
(
subject
=
param
,
error
=
"
Parameter {}
"
"
has empty
type
"
.
format
(
idx
)))
error
=
"
Parameter {}
({}) has empty
"
"
type
"
.
format
(
idx
,
p_name
)))
for
idx
,
kpi
in
enumerate
(
mco
.
kpis
):
if
len
(
kpi
.
name
.
strip
())
==
0
:
errors
.
append
(
VerifierError
(
subject
=
kpi
,
error
=
"
KPI {} has empty name
"
.
format
(
idx
)))
if
len
(
kpi
.
objective
.
strip
())
==
0
:
if
kpi
.
objective
==
''
:
errors
.
append
(
VerifierError
(
subject
=
kpi
,
error
=
"
KPI {} has empty
"
"
objective
"
.
format
(
idx
)))
...
...
@@ -85,7 +86,7 @@ def _check_execution_layers(workflow):
return
errors
def
_check_data_source
(
data_source_model
,
layer_n
o
):
def
_check_data_source
(
data_source_model
,
layer_n
umber
):
errors
=
[]
factory
=
data_source_model
.
factory
...
...
@@ -113,26 +114,30 @@ def _check_data_source(data_source_model, layer_no):
errors
.
append
(
VerifierError
(
subject
=
data_source_model
,
error
=
"
Missing input slot name assignment
"
"
in layer {}
"
.
format
(
layer_n
o
)))
"
in layer {}
"
.
format
(
layer_n
umber
)))
for
idx
,
info
in
enumerate
(
data_source_model
.
input_slot_info
):
if
len
(
info
.
name
.
strip
())
==
0
:
errors
.
append
(
VerifierError
(
subject
=
data_source_model
,
error
=
"
Undefined name for input
"
"
parameter {} in layer {}
"
.
format
(
idx
,
layer_no
)))
"
parameter {} of {} in layer {}
"
.
format
(
idx
,
factory
.
name
,
layer_number
)))
if
len
(
output_slots
)
!=
len
(
data_source_model
.
output_slot_info
):
errors
.
append
(
VerifierError
(
subject
=
data_source_model
,
error
=
"
Missing output slot name assignment
"
"
in layer {}
"
.
format
(
layer_n
o
)))
"
in layer {}
"
.
format
(
layer_n
umber
)))
for
idx
,
info
in
enumerate
(
data_source_model
.
output_slot_info
):
if
len
(
info
.
name
.
strip
())
==
0
:
errors
.
append
(
VerifierError
(
subject
=
data_source_model
,
error
=
"
Undefined name for output
"
"
parameter {} in layer {}
"
.
format
(
idx
,
layer_no
)))
"
parameter {} of {} in layer {}
"
.
format
(
idx
,
factory
.
name
,
layer_number
)))
return
errors
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment