Skip to content
Snippets Groups Projects
Commit 5b585255 authored by Jerome Forissier's avatar Jerome Forissier Committed by Jérôme Forissier
Browse files

common.mk: fix invalid empty test on $(LAUNCH_TERMINAL)


When LAUNCH_TERMINAL is not set, `make run` hangs with the following
messages:

 soc_term: save_current_termios: tcgetattr: Inappropriate ioctl for device
 soc_term: save_current_termios: tcgetattr: Inappropriate ioctl for device

The reason is an invalid test in common.mk.

Fixes: 07580605 ("common.mk: allow user to override launch-terminal in make run")
Signed-off-by: default avatarJerome Forissier <jerome.forissier@linaro.org>
Acked-by: default avatarEtienne Carriere <etienne.carriere@linaro.org>
Acked-by: default avatarJens Wiklander <jens.wiklander@linaro.org>
parent 46f85856
No related branches found
No related tags found
No related merge requests found
......@@ -243,7 +243,7 @@ define run-help
@echo
endef
ifneq ("", $(LAUNCH_TERMINAL))
ifneq (, $(LAUNCH_TERMINAL))
define launch-terminal
@nc -z 127.0.0.1 $(1) || \
$(LAUNCH_TERMINAL) $(SOC_TERM_PATH)/soc_term $(1) &
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment